Skip to content

fix(tests): run-all.sh opens no browser tabs (MXTK_NO_GUIDE=1) - #779

Merged
MendixMau merged 3 commits into
masterfrom
fix/tests-no-guide-tab
Nov 16, 2026
Merged

MendixMau merged 3 commits into
masterfrom
fix/tests-no-guide-tab

Conversation

@MendixMau

Copy link
Copy Markdown
Owner

Direct lane

What changed and why (one paragraph): a local full run of tests/wave2/run-all.sh on macOS kept opening toolkit-guide.html in the real browser: every fixture that scaffolds a fresh project through bin/init-project.sh hits the first-touch auto-open, and only some fixtures set MXTK_NO_GUIDE=1. The runner now exports it next to MXTK_LEAKGUARD_DENYFILE. test-guide-reopen.sh unsets it, because it tests the opening itself with a fake open on PATH.

Impact

Row Answer
Process none
Dependencies none: no shared lib touched; tests only
Context cost none: no routed or always-loaded file touched
Behaviour n/a: scripts only
Runtime n/a (one env var)

Field evidence: local full suite on macOS opened a new guide tab per scaffolding fixture for the whole run. MXTK_NO_GUIDE=1 bash tests/wave2/test-guide-reopen.sh: 10/10 with this change; the pre-change test under the same env: 3 pass, 7 FAIL (so the unset is needed).

  • No client data anywhere in the diff
  • Size cap: 3 files, 8 lines
  • Test tier reached: T1, the affected fixture under the suite env plus a negative control; bash -n on run-all.sh
  • New/changed instrument: n/a
  • New skill: n/a
  • CHANGELOG.md line appended
  • Bug entries: n/a

🤖 Generated with Claude Code

…browser tabs

Every fixture that scaffolds through bin/init-project.sh opened toolkit-guide.html in the
developer's real browser. test-guide-reopen.sh unsets it: it tests the opening with a fake open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MendixMau

Copy link
Copy Markdown
Owner Author

Review: MERGE-AFTER-FIX. The fix is right, but CI checks fails on this PR's own CHANGELOG line: it has no — <credit> segment (bin/check-pr-discipline.sh:88-112).

Value: Fixes the reported problem.

  • bin/init-project.sh:713 opens the guide unless MXTK_NO_GUIDE is set, and only some fixtures set it.
  • Exporting it once in tests/wave2/run-all.sh:29 reaches every fixture (run-all.sh:75).
  • test-guide-reopen.sh:21 unsets it because that fixture tests the opening itself.

Nothing is overbuilt: 3 files, 8 lines.

Regression risk: None for consuming projects: only tests/wave2/ and CHANGELOG change. Inside the suite, init also skips writing .claude/.guide-shown when the variable is set. Only test-guide-reopen.sh checks that, and it unsets the variable. Its case 4 still covers suppression. Safe on bash 3.2 and Git Bash. Merges cleanly.

Correctness: No bugs. Run in a detached worktree:

Fixture version Env Result
head MXTK_NO_GUIDE=1 10/0
head without it 10/0
merge-base (negative control) MXTK_NO_GUIDE=1 8/2

So the unset is needed. The body says 3/7; the count differs but the conclusion holds.

Context cost: 66,196 → 66,196 words (measured).

Time cost: n/a. No hot-path file is touched and no check is added.

CI: run 43799436625, step "PR discipline": FAIL CHANGELOG entry added without a credit segment. This PR caused it, not master: the merge-base and every master run since 04:09Z are green.

Exact fixes required:

  1. Change the end of CHANGELOG.md:22 to … with a fake \open` — Maurits Visser, from a local full-suite run, then confirm checks` goes green.

Generated by Claude Code

@MendixMau

Copy link
Copy Markdown
Owner Author

Review: MERGE (re-review). The credit segment landed in 8fc27f2: the line now ends — Maurits Visser, from a local full-suite run. On head b1eb8a9, check-pr-discipline.sh origin/master is clean (rc=0).

The master merge b1eb8a9 keeps every line. The diff against origin/master is only this PR's +8 lines in 3 files, and all master Unreleased entries are intact.

test-guide-reopen.sh passes 10/0, with and without MXTK_NO_GUIDE.

Nit: a stray blank line inside ## Unreleased. It is cosmetic, because cut-release.sh counts only ^- lines.


Generated by Claude Code

@MendixMau
MendixMau merged commit 3f921ec into master Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants