Repository navigation
fix(tests): run-all.sh opens no browser tabs (MXTK_NO_GUIDE=1) - #779
Conversation
…browser tabs Every fixture that scaffolds through bin/init-project.sh opened toolkit-guide.html in the developer's real browser. test-guide-reopen.sh unsets it: it tests the opening with a fake open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review: MERGE-AFTER-FIX. The fix is right, but CI Value: Fixes the reported problem.
Nothing is overbuilt: 3 files, 8 lines. Regression risk: None for consuming projects: only Correctness: No bugs. Run in a detached worktree:
So the Context cost: 66,196 → 66,196 words (measured). Time cost: n/a. No hot-path file is touched and no check is added. CI: run 43799436625, step "PR discipline": Exact fixes required:
Generated by Claude Code |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE (re-review). The credit segment landed in 8fc27f2: the line now ends The master merge b1eb8a9 keeps every line. The diff against origin/master is only this PR's +8 lines in 3 files, and all master Unreleased entries are intact.
Nit: a stray blank line inside Generated by Claude Code |
Direct lane
What changed and why (one paragraph): a local full run of
tests/wave2/run-all.shon macOS kept openingtoolkit-guide.htmlin the real browser: every fixture that scaffolds a fresh project throughbin/init-project.shhits the first-touch auto-open, and only some fixtures setMXTK_NO_GUIDE=1. The runner now exports it next toMXTK_LEAKGUARD_DENYFILE.test-guide-reopen.shunsets it, because it tests the opening itself with a fakeopenon PATH.Impact
Field evidence: local full suite on macOS opened a new guide tab per scaffolding fixture for the whole run.
MXTK_NO_GUIDE=1 bash tests/wave2/test-guide-reopen.sh: 10/10 with this change; the pre-change test under the same env: 3 pass, 7 FAIL (so the unset is needed).bash -non run-all.shCHANGELOG.mdline appended🤖 Generated with Claude Code